mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 53061: Added abstractions for working with POSIX resource limits.
Date Thu, 20 Oct 2016 22:39:07 GMT


> On Oct. 20, 2016, 9:09 p.m., Jie Yu wrote:
> > src/posix/rlimit.hpp, line 25
> > <https://reviews.apache.org/r/53061/diff/2/?file=1542386#file1542386line25>
> >
> >     Windows does not use autotool. So you don't have to do this. We just need to
make sure all callsites are wrapped with ifndef WINDOWS.

Not sure how this is related to autotools, but I removed it nevertheless.


> On Oct. 20, 2016, 9:09 p.m., Jie Yu wrote:
> > src/posix/rlimit.cpp, lines 130-134
> > <https://reviews.apache.org/r/53061/diff/2/?file=1542387#file1542387line130>
> >
> >     Why do you need to call `getrlimit` here?

Removed.


> On Oct. 20, 2016, 9:09 p.m., Jie Yu wrote:
> > src/common/parse.hpp, line 179
> > <https://reviews.apache.org/r/53061/diff/2/?file=1542384#file1542384line179>
> >
> >     please add to `src/v1/parse.hpp` as well

Also added an `operator<<` in v1.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53061/#review153435
-----------------------------------------------------------


On Oct. 21, 2016, 12:38 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53061/
> -----------------------------------------------------------
> 
> (Updated Oct. 21, 2016, 12:38 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-6426
>     https://issues.apache.org/jira/browse/MESOS-6426
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This commit adds high-level functions to set POSIX resource limits and
> associated protobuf definitions.
> 
> This is intended to be used by the containerizer in later changes.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 9a268dd0aa2f5ee245ad26bf40ab9b12fe861d2f 
>   include/mesos/type_utils.hpp 88c7bcf7e8c3053e6e8bb78c67bf93b8276ac053 
>   include/mesos/v1/mesos.proto 855377f56e1693e11b3c0c0cb61a2c3013a66f54 
>   src/CMakeLists.txt e60d34ca4b714bb237d5864b4682280f11b147a6 
>   src/Makefile.am 05fe8fa3e3409b35ba66d7e7238e988fb0fab07d 
>   src/common/parse.hpp ee26717ed54445f57fa3a11c74ece8fe0861bd40 
>   src/common/type_utils.cpp e249fae458d0fc1d32ea4e8b4a26d1a2d75826f1 
>   src/posix/rlimit.hpp PRE-CREATION 
>   src/posix/rlimit.cpp PRE-CREATION 
>   src/v1/mesos.cpp 4c8ee9121db08e5c462b9b611c692b751cfbf40b 
>   src/v1/parse.hpp 8882b32e0ee833cc1e261c7dde0bea4e844b7416 
> 
> Diff: https://reviews.apache.org/r/53061/diff/
> 
> 
> Testing
> -------
> 
> Tested as part of https://reviews.apache.org/r/53078/.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message