mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 53063: WIP: Added rlimit isolator.
Date Thu, 20 Oct 2016 19:28:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53063/#review153442
-----------------------------------------------------------



Patch looks great!

Reviews applied: [53061, 53062, 53063]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Oct. 20, 2016, 4:33 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53063/
> -----------------------------------------------------------
> 
> (Updated Oct. 20, 2016, 4:33 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-6426
>     https://issues.apache.org/jira/browse/MESOS-6426
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This commit adds an isolator for POSIX resource limits. Since the
> containerizer sets limits as the user of the container setting
> permissions beyond the configured system limits likely is only
> supported for containers running as root.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 9a268dd0aa2f5ee245ad26bf40ab9b12fe861d2f 
>   include/mesos/slave/containerizer.proto 94e8cb4c37aa2a06c59726773834812c5eb660d8 
>   include/mesos/v1/mesos.proto 855377f56e1693e11b3c0c0cb61a2c3013a66f54 
>   src/Makefile.am 05fe8fa3e3409b35ba66d7e7238e988fb0fab07d 
>   src/slave/containerizer/mesos/containerizer.cpp eac70d955e08142a2d054039d610a3d516b1b57e

>   src/slave/containerizer/mesos/isolators/posix/rlimit.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/posix/rlimit.cpp PRE-CREATION 
>   src/tests/containerizer/posix_rlimit_isolator_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/53063/diff/
> 
> 
> Testing
> -------
> 
> Tested as part of https://reviews.apache.org/r/53061/.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message