mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Re: Review Request 53041: Added `setxattr()` and `getxattr()` in stout.
Date Thu, 20 Oct 2016 04:03:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53041/#review153347
-----------------------------------------------------------




3rdparty/stout/include/stout/os/posix/xattr.hpp (line 24)
<https://reviews.apache.org/r/53041/#comment222646>

    Since the flags differ between platform, it might be a good idea to define stout-specific
versions.



3rdparty/stout/include/stout/os/posix/xattr.hpp (line 51)
<https://reviews.apache.org/r/53041/#comment222647>

    Add a flags argument? Darwin's ``XATTR_NOFOLLOW`` can be mapped to ``lgetxattr`` on Linux.



3rdparty/stout/include/stout/os/posix/xattr.hpp (line 64)
<https://reviews.apache.org/r/53041/#comment222648>

    You could use ``std::vector<char>`` here to avoid manual memory management.



3rdparty/stout/include/stout/os/posix/xattr.hpp (line 80)
<https://reviews.apache.org/r/53041/#comment222649>

    Should you add ``removexattr`` for completeness?



3rdparty/stout/include/stout/os/xattr.hpp (line 21)
<https://reviews.apache.org/r/53041/#comment222645>

    I don't think this API makes sense for Windows. NTFS has streams, which have different
semantics that extended attributes. I doubt that you would want this API on Windows.


- James Peach


On Oct. 20, 2016, 3:20 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53041/
> -----------------------------------------------------------
> 
> (Updated Oct. 20, 2016, 3:20 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-6360
>     https://issues.apache.org/jira/browse/MESOS-6360
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added `setxattr()` and `getxattr()` in stout.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/Makefile.am 1eb9c146d3eebacaea32e0f724d145f0c1dd676f 
>   3rdparty/stout/include/stout/os.hpp 96e8621b198a3ec4cce78e0a6ff5f271eda05ff1 
>   3rdparty/stout/include/stout/os/posix/xattr.hpp PRE-CREATION 
>   3rdparty/stout/include/stout/os/windows/xattr.hpp PRE-CREATION 
>   3rdparty/stout/include/stout/os/xattr.hpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/53041/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message