mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 52783: Added documentation for mesos-containerizer Linux capabilities support.
Date Tue, 18 Oct 2016 07:51:59 GMT


> On Oct. 18, 2016, 6:55 a.m., Avinash sridharan wrote:
> > docs/linux_capabilities.md, line 3
> > <https://reviews.apache.org/r/52783/diff/3/?file=1539582#file1539582line3>
> >
> >     s/described/describes
> >     
> >     to add support for `Linux Capabilities`

I do not understand your second request. How should the sentence read after applying you suggestion?


> On Oct. 18, 2016, 6:55 a.m., Avinash sridharan wrote:
> > docs/configuration.md, line 1003
> > <https://reviews.apache.org/r/52783/diff/3/?file=1539581#file1539581line1003>
> >
> >     s/the agent/that the agent/

Not a native speaker but to me this seems to just make the sentence more wordy (and one should
probably use `which` instead of `that`). Maybe a native speaker could chime in how this should
be phrased.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52783/#review153028
-----------------------------------------------------------


On Oct. 18, 2016, 9:51 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52783/
> -----------------------------------------------------------
> 
> (Updated Oct. 18, 2016, 9:51 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-6376
>     https://issues.apache.org/jira/browse/MESOS-6376
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added documentation for mesos-containerizer Linux capabilities support.
> 
> 
> Diffs
> -----
> 
>   docs/configuration.md c83a58eb6884c8d8c37880a745e04cf0b789ebdc 
>   docs/linux_capabilities.md PRE-CREATION 
>   docs/mesos-containerizer.md 76544625838845fe2817347fea483a60ab250f99 
> 
> Diff: https://reviews.apache.org/r/52783/diff/
> 
> 
> Testing
> -------
> 
> Checked with local renderer.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message