mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haosdent huang <>
Subject Re: Review Request 52470: Filled missing executor info in tasks when `LAUNCH_GROUP`.
Date Thu, 13 Oct 2016 06:36:34 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Oct. 13, 2016, 6:36 a.m.)

Review request for mesos, Anand Mazumdar and Vinod Kone.


Address @vinodkone's comments.

Bugs: MESOS-6283

Repository: mesos


This fixed the navigate error in Web UI because Web UI uses the
executor id of the task to search the corresponding sandbox directory.
Web UI uses the task id as the executor id if the executor id of the
task is empty when searching the sandbox directory. It works fine when
tasks are launched by `CommandExecutor` because the executor id of the
task is equal to the task id in this case. However, when tasks are
launched by `DefaultExecutor`, the executor id of the task is defined
in the framework side and may different with the task id. So we need to
fill the `ExecutorInfo` of the `TaskInfo` when `LAUNCH_GROUP` to avoid
the Web UI uses incorrect executor id to search sandbox directory.

Diffs (updated)

  include/mesos/mesos.proto 05988d4a5cc387f6eafe6453170bcc8764ee1247 
  include/mesos/v1/mesos.proto 08a536cf345663f81d03e53625c640f946ce5079 
  src/master/master.hpp 43518b9bf1bfaa54e26acc7f2e70c4161c667a84 
  src/master/master.cpp 7ef898781ce5c2349ffeaa3ce43e68dede19c852 
  src/master/validation.cpp e5da3c9bf0a1042b42522f1ab74ce798fbb1738d 
  src/tests/default_executor_tests.cpp 9e0fd678a7f5e9c2288fbb11a60cf6f339efa24f 
  src/tests/master_validation_tests.cpp 99e350e0587e73e9ee25ef20dd369cd146bd446a 



Add new test case `DefaultExecutorTest.ROOT_TaskUsesExecutor`.


haosdent huang

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message