mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haosdent huang <>
Subject Re: Review Request 52470: Filled missing executor info in tasks when `LAUNCH_GROUP`.
Date Wed, 12 Oct 2016 09:29:20 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Oct. 12, 2016, 9:29 a.m.)

Review request for mesos, Anand Mazumdar and Vinod Kone.


Address @vinodkone's comments.

Bugs: MESOS-6283

Repository: mesos


This fixed the navigate error in Web UI because Web UI uses the
executor id of the task to search the corresponding sandbox directory.
Web UI uses the task id as the executor id if the executor id of the
task is empty when searching the sandbox directory. It works fine when
tasks are launched by `CommandExecutor` because the executor id of the
task is equal to the task id in this case. However, when tasks are
launched by `DefaultExecutor`, the executor id of the task is defined
in the framework side and may different with the task id. So we need to
fill the `ExecutorInfo` of the `TaskInfo` when `LAUNCH_GROUP` to avoid
the Web UI uses incorrect executor id to search sandbox directory.

Diffs (updated)

  include/mesos/mesos.proto 7d0201ead69c816b9d51f1a41cd64a8f922b069d 
  include/mesos/v1/mesos.proto 301d1aedca7ac0729229ba9b05e5bf2b79f286a5 
  src/master/master.hpp 43518b9bf1bfaa54e26acc7f2e70c4161c667a84 
  src/master/master.cpp ad8993ae43e2508a3777f4062acaca1177ac77f2 
  src/master/validation.cpp e5da3c9bf0a1042b42522f1ab74ce798fbb1738d 


Testing (updated)


haosdent huang

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message