mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 52756: Invoke the shutdown executor callback for checkpointed frameworks.
Date Wed, 12 Oct 2016 08:11:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52756/#review152283
-----------------------------------------------------------



Patch looks great!

Reviews applied: [52755, 52756]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Oct. 12, 2016, 12:15 a.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52756/
> -----------------------------------------------------------
> 
> (Updated Oct. 12, 2016, 12:15 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-6370
>     https://issues.apache.org/jira/browse/MESOS-6370
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Previously, the executor library used to commit suicide after the
> recovery timeout without invoking the executor's shutdown callback.
> This behavior was not consistent with the executor driver.
> 
> 
> Diffs
> -----
> 
>   src/executor/executor.cpp a0e5d8382fa3886b747ae92507dce17e75c2d749 
> 
> Diff: https://reviews.apache.org/r/52756/diff/
> 
> 
> Testing
> -------
> 
> Manual testing (It's hard to test this directly owing to the executor library immediately
invoking the `connected()` callback since the libprocess instance initialized in tests is
always active!)
> 
> Filed MESOS-6373 to address this.
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message