mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 52470: Set executor id in `protobuf::createTask`.
Date Mon, 10 Oct 2016 18:54:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52470/#review152034
-----------------------------------------------------------



I think it's probably worth to just mutate TaskInfo like you did in the very first diff rather
than doing all these changes. They are bit messy and incomplete.


src/master/http.cpp (line 3776)
<https://reviews.apache.org/r/52470/#comment220715>

    I think this should be
    
    ```
    const Option<ExecutorID> executorId = taskInfo.has_executor()
      ? taskInfo.executor().executor_id()
      : None()
    
    ```
    
    This is not completely true because we won't set ExecutorId for default executor. But
atleast it won't break custom/command executor tasks.



src/slave/http.cpp (line 1391)
<https://reviews.apache.org/r/52470/#comment220725>

    ditto.



src/slave/http.cpp (lines 1408 - 1415)
<https://reviews.apache.org/r/52470/#comment220730>

    this means we won't be setting executorId for legacy custom executors that do not set
type to `CUSTOM` (which we allow).



src/slave/slave.cpp (line 1383)
<https://reviews.apache.org/r/52470/#comment220727>

    ditto.



src/slave/slave.cpp (lines 1401 - 1409)
<https://reviews.apache.org/r/52470/#comment220729>

    this means we won't be setting executorId for legacy custom executors that do not set
type to `CUSTOM` (which we allow).



src/slave/slave.cpp (lines 6537 - 6543)
<https://reviews.apache.org/r/52470/#comment220731>

    this means we won't be setting executorId for legacy custom executors that do not set
type to `CUSTOM` (which we allow).



src/slave/slave.cpp (lines 6590 - 6596)
<https://reviews.apache.org/r/52470/#comment220732>

    ditto.



src/slave/slave.cpp (lines 6667 - 6670)
<https://reviews.apache.org/r/52470/#comment220733>

    ditto.


- Vinod Kone


On Oct. 8, 2016, 12:20 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52470/
> -----------------------------------------------------------
> 
> (Updated Oct. 8, 2016, 12:20 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-6283
>     https://issues.apache.org/jira/browse/MESOS-6283
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Set executor id in `protobuf::createTask`.
> 
> 
> Diffs
> -----
> 
>   src/common/protobuf_utils.hpp 80c66c4f7d52fc184e7553d173195ba7714971d4 
>   src/common/protobuf_utils.cpp 7362b875ce1ffca6bc6376169a11494bdb9cf062 
>   src/master/http.cpp bb9c87327dfe2161a6f1fd4cded72aa9a5ffaf66 
>   src/master/master.hpp 43518b9bf1bfaa54e26acc7f2e70c4161c667a84 
>   src/master/master.cpp ad8993ae43e2508a3777f4062acaca1177ac77f2 
>   src/slave/http.cpp 79061c3cd94d856ec695e5a82bf6792bf089d1f8 
>   src/slave/slave.cpp 119fb36c27b25739f2a86a55d48e964ca4a84ff7 
>   src/tests/command_executor_tests.cpp 6e47243941626bb5b6224430f9a12ced8a3f5062 
>   src/tests/common/http_tests.cpp aea338674f1a3b769958af134d1435292b827ba7 
>   src/tests/slave_recovery_tests.cpp 703948f7a6861a4401ee45ce9cae2644106083f3 
> 
> Diff: https://reviews.apache.org/r/52470/diff/
> 
> 
> Testing
> -------
> 
> Add a new test case `CommandExecutorTest.EmptyExecutorIdInTask`.
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message