mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <an...@apache.org>
Subject Re: Review Request 52638: Populated `recovered` field in `GetAgents` response.
Date Mon, 10 Oct 2016 18:53:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52638/#review152036
-----------------------------------------------------------



Would you be following up with the change to `/state` in a separate review?


src/master/http.cpp (lines 2315 - 2316)
<https://reviews.apache.org/r/52638/#comment220716>

    Nit: Combine these two statements?
    
    ```cpp
    getAgents.add_recovered()->CopyFrom(slaveId);
    ```


- Anand Mazumdar


On Oct. 7, 2016, 4 p.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52638/
> -----------------------------------------------------------
> 
> (Updated Oct. 7, 2016, 4 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Xiaojian Huang.
> 
> 
> Bugs: MESOS-6177
>     https://issues.apache.org/jira/browse/MESOS-6177
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Populated `recovered` field in `GetAgents` response.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp bb9c87327dfe2161a6f1fd4cded72aa9a5ffaf66 
> 
> Diff: https://reviews.apache.org/r/52638/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message