mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 52568: Added support for nested containers to the test containerizer.
Date Thu, 06 Oct 2016 00:11:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52568/#review151603
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/containerizer.hpp (line 134)
<https://reviews.apache.org/r/52568/#comment220036>

    not yours, but new line here?



src/tests/containerizer.cpp (lines 125 - 126)
<https://reviews.apache.org/r/52568/#comment220028>

    why do you use `at` here but `[]` up above in the constructors?


- Vinod Kone


On Oct. 5, 2016, 8:45 p.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52568/
> -----------------------------------------------------------
> 
> (Updated Oct. 5, 2016, 8:45 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> In the process, the maps that were stored were simplified.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer.hpp 3cf418a040dfedad2eb6d771e7cc9cc179bcf55c 
>   src/tests/containerizer.cpp 89c5400d3a2e771278ba370a939a6c68bc57a31f 
> 
> Diff: https://reviews.apache.org/r/52568/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message