mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jiang Yan Xu <...@jxu.me>
Subject Re: Review Request 51999: Refactor parsing of resources.
Date Wed, 05 Oct 2016 18:07:25 GMT


> On Oct. 5, 2016, 11:06 a.m., Jiang Yan Xu wrote:
> > include/mesos/resources.hpp, line 167
> > <https://reviews.apache.org/r/51999/diff/7/?file=1519236#file1519236line167>
> >
> >     "If that fails" gave me the wrong idea of the condition under which the method
would then call `fromSimpleString()` (so I suggested `fromJSONString(text, role)`).
> >     
> >     
> >     We are basically just replying on the input type and not "failures" to choose
the parsing mechanism so would the following be more clear?
> >     
> >     ````
> >     Parses Resources from text in the form of a JSON array or as a simple string
in the form of "name(role):value;name:value;...". i.e, this
> >     method calls `fromJSONArray()` or `fromSimpleString()` and validates the resulting
`vector<Resource>` before converting it to a `Resources` object.
> >     ```
> >     
> >     The last part of the paragraph may be implied but I think it makes it more clear.

s/replying/relying/


- Jiang Yan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51999/#review151115
-----------------------------------------------------------


On Oct. 3, 2016, 4:46 p.m., Anindya Sinha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51999/
> -----------------------------------------------------------
> 
> (Updated Oct. 3, 2016, 4:46 p.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-6062
>     https://issues.apache.org/jira/browse/MESOS-6062
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Refactored `Resources::parse()` into 2 separate static functions:
> 1. Resources::fromJSONString() to parse JSON representation of
>    resources.
> 2. Resources::fromSimpleString() to parse text representation of
>    resources.
> 
> Since these 2 new functions return a `Try<vector<Resource>>`, the
> existing `Resources::parse()` implicitly converts that to a
> `Resources` object. This refactor is done to retrieve all resources
> (include empty resources) required for auto detection of root
> and MOUNT disks.
> 
> 
> Diffs
> -----
> 
>   include/mesos/resources.hpp 3ef8cacee529addc745b4aeb6398d7606c61b749 
>   include/mesos/v1/resources.hpp ef56b4960b103a3efd916fab64796aa334ba44c6 
>   src/common/resources.cpp 0774ff0669e831494d5b12b88e19dfa0a4a3f757 
>   src/tests/resources_tests.cpp 3e493007d6d1d8194d07035aaa1cde28dedf2b5a 
>   src/v1/resources.cpp 62a644ebbd13cfc0862bd118ba16c43e0f6aaf90 
> 
> Diff: https://reviews.apache.org/r/51999/diff/
> 
> 
> Testing
> -------
> 
> All tests passed.
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message