mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 52252: Added test case `HealthCheckTest.ROOT_DOCKER_DockerHealthyTaskViaHTTP`.
Date Wed, 05 Oct 2016 16:53:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52252/#review151515
-----------------------------------------------------------




src/tests/health_check_tests.cpp (lines 1540 - 1541)
<https://reviews.apache.org/r/52252/#comment219930>

    Let's do it as a separate patch in the whole file at once.



src/tests/health_check_tests.cpp (lines 1543 - 1545)
<https://reviews.apache.org/r/52252/#comment219931>

    Either put allocation interval back or remove the flags ; )



src/tests/health_check_tests.cpp (line 1547)
<https://reviews.apache.org/r/52252/#comment219932>

    Could you please rename all relevant s/flags/agentFlags in this file? As a separate patch,
please!


- Alexander Rukletsov


On Oct. 5, 2016, 4:10 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52252/
> -----------------------------------------------------------
> 
> (Updated Oct. 5, 2016, 4:10 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Gastón Kleiman.
> 
> 
> Bugs: MESOS-6278
>     https://issues.apache.org/jira/browse/MESOS-6278
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added test case `HealthCheckTest.ROOT_DOCKER_DockerHealthyTaskViaHTTP`.
> 
> 
> Diffs
> -----
> 
>   src/tests/health_check_tests.cpp f4a63e2f5def022bf4469920861e6a5af229af96 
> 
> Diff: https://reviews.apache.org/r/52252/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message