mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 52185: Do not need to erase task if it not in pendingTasks.
Date Mon, 03 Oct 2016 23:50:54 GMT


> On Oct. 3, 2016, 11:50 p.m., Vinod Kone wrote:
> > src/master/master.cpp, line 4112
> > <https://reviews.apache.org/r/52185/diff/2/?file=1508851#file1508851line4112>
> >
> >     Dont think this change is necessary. I would rather have all the removals related
to pending (framework map and slave map) in one place.

Please discard this review if you agree.


- Vinod


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52185/#review151258
-----------------------------------------------------------


On Sept. 23, 2016, 2:43 a.m., Andy Pang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52185/
> -----------------------------------------------------------
> 
> (Updated Sept. 23, 2016, 2:43 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> If task has not been in hashmap pendingTasks, indicate it has been erase, so don't need
to erase twice.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp 66a672f 
> 
> Diff: https://reviews.apache.org/r/52185/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Andy Pang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message