mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 52010: Supported filesystem linux isolator to be nested aware.
Date Wed, 28 Sep 2016 20:19:02 GMT


> On Sept. 28, 2016, 1:11 p.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/isolators/filesystem/linux.cpp, lines 278-298
> > <https://reviews.apache.org/r/52010/diff/2/?file=1511506#file1511506line278>
> >
> >     This is not correct, if we do that, we'll break Docker containerizer. Please
see the comments in the original code.

This is only for nested containers. We dont have nested containers in docker containerizer,
right?


- Gilbert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52010/#review150753
-----------------------------------------------------------


On Sept. 27, 2016, 10:49 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52010/
> -----------------------------------------------------------
> 
> (Updated Sept. 27, 2016, 10:49 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Joseph Wu, Kevin
Klues, and Vinod Kone.
> 
> 
> Bugs: MESOS-6191
>     https://issues.apache.org/jira/browse/MESOS-6191
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Supported filesystem linux isolator to be nested aware.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/filesystem/linux.hpp 0a85935550e36c9142d845465cfa70a1634a647a

>   src/slave/containerizer/mesos/isolators/filesystem/linux.cpp ea418252956c8089acc5a491888ed7f6df6cafcd

> 
> Diff: https://reviews.apache.org/r/52010/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message