mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 52334: Removed 'directory' in nested container launch interface.
Date Wed, 28 Sep 2016 05:01:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52334/
-----------------------------------------------------------

(Updated Sept. 27, 2016, 10:01 p.m.)


Review request for mesos, Benjamin Mahler, Greg Mann, Artem Harutyunyan, Jie Yu, and Vinod
Kone.


Bugs: MESOS-6263
    https://issues.apache.org/jira/browse/MESOS-6263


Repository: mesos


Description
-------

In this patch, the containerizer launch method for nested containers
should be responsible for figuring out the sandbox directory for the
nested container. So we can avoid passing an extra parameter to the
nested launch interface, and there is no need for the agent to figure
out the nested sandbox.


Diffs (updated)
-----

  src/slave/containerizer/containerizer.hpp 5f8901ffbbdc9277dda3218ccdedc1f33b1ea2bd 
  src/slave/containerizer/mesos/containerizer.hpp 83cd53e77cebf64b0d9efec058d8abd4e855cd9c

  src/slave/containerizer/mesos/containerizer.cpp ac2823f5452bb336b2f4eb96f65c484a5aa64f6d

  src/slave/http.cpp 824bebef25dfbd4a6c92423f77e65729b5e10eab 
  src/tests/api_tests.cpp 1aa6a2bb1060d4b3307bf9ee8be7da87eada8da8 
  src/tests/containerizer/mock_containerizer.hpp 204fa2ab16b5fa448914e124aac559fbc5d383f5


Diff: https://reviews.apache.org/r/52334/diff/


Testing
-------

make check


Thanks,

Gilbert Song


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message