mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <>
Subject Re: Review Request 52129: Windows: Fixed subprocess and setsid compilation errors.
Date Wed, 21 Sep 2016 20:31:20 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Sept. 21, 2016, 1:31 p.m.)

Review request for mesos, Daniel Pravat, Artem Harutyunyan, and Jie Yu.


Done testing.

Repository: mesos


This changes the `ChildHook::SETSID` to a noop on Windows
as there is no equivalent functionality on this OS.

By default, the lifetime of child processes on Windows are not
tied to the parent process (`setsid()` on Posix prevents child
processes from dying when the parent dies).


  3rdparty/libprocess/src/subprocess.cpp 6f50a714285cd7bc05d57c476e400a1fa5246796 


Testing (updated)

make check (OSX)

msbuild Mesos.sln ... (Windows)


Joseph Wu

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message