mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 51953: Changed registrar operations to no longer depend on "strict" flag.
Date Fri, 16 Sep 2016 19:01:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51953/#review149241
-----------------------------------------------------------




src/master/master.hpp (line 1935)
<https://reviews.apache.org/r/51953/#comment216800>

    looks like our style is to add a comment about the unused parameter.
    
    https://github.com/apache/mesos/blob/master/src/slave/slave.hpp#L487


- Vinod Kone


On Sept. 16, 2016, 12:58 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51953/
> -----------------------------------------------------------
> 
> (Updated Sept. 16, 2016, 12:58 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-5951
>     https://issues.apache.org/jira/browse/MESOS-5951
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Registrar operations to admit and remove slaves now behave the same way,
> regardless of the value of the "strict" flag.
> 
> This commit changes the behavior of these operations by enabling the
> previous "strict" behavior. For example, removing a slave that is not
> registered results in an `Error`, rather than silently ignoring the
> problem. However, the master should never attempt to remove a slave that
> is not registered, so this is a useful invariant to check. Similarly,
> attempting to admit a slave that is already admitted will now result in
> an `Error`; this should only occur when there is a slave ID collision,
> so again it seems appropriate to produce an error rather than ignoring
> the problem.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp 4992ab0a0bb5babbf6a4fa3e6eff3577590fc879 
>   src/master/master.cpp b88472f6350d3f71e057bab34822423da5427151 
>   src/tests/registrar_tests.cpp b04fc92c66449f1094212a534899e16d5f6f01bd 
> 
> Diff: https://reviews.apache.org/r/51953/diff/
> 
> 
> Testing
> -------
> 
> `make check` on OSX and Linux.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message