mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 51865: Added validation for `ContainerInfo`.
Date Fri, 16 Sep 2016 07:43:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51865/#review149177
-----------------------------------------------------------


Fix it, then Ship it!




Thanks! LGTM! Ship it!


src/tests/master_validation_tests.cpp (lines 1761 - 1762)
<https://reviews.apache.org/r/51865/#comment216716>

    Do we need this? Couldn't we set_image directly?



src/tests/master_validation_tests.cpp (lines 1939 - 1940)
<https://reviews.apache.org/r/51865/#comment216717>

    ditto.



src/tests/master_validation_tests.cpp (lines 2031 - 2032)
<https://reviews.apache.org/r/51865/#comment216718>

    Just nits:
    
    Either move below
    `task1.mutable_container()->add_network_infos();`
    
    or newline below L2032.


- Gilbert Song


On Sept. 15, 2016, 6:34 a.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51865/
> -----------------------------------------------------------
> 
> (Updated Sept. 15, 2016, 6:34 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-6157
>     https://issues.apache.org/jira/browse/MESOS-6157
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/master/validation.cpp aa743d730bebebc0353fa0a7a31f68bc94e7e25d 
>   src/tests/container_logger_tests.cpp 1b121a2fcce2d874aeefc4257b9d4e594866e78d 
>   src/tests/containerizer/cni_isolator_tests.cpp 0d611c196870b6adabea52a48abcd344c8dad5d1

>   src/tests/containerizer/docker_containerizer_tests.cpp 1671d45171307cda62184505ce1dbadc476abca6

>   src/tests/containerizer/docker_volume_isolator_tests.cpp ca7bffd3b1773a11a4679d114885d3edd977b02b

>   src/tests/containerizer/filesystem_isolator_tests.cpp df4642d2667407b1758ffe2efcfdbf9968cf2c33

>   src/tests/containerizer/isolator_tests.cpp 9bb1e69209f34b18b5b64c3daf5ea26780f2ab74

>   src/tests/master_validation_tests.cpp 16c5773aa44016f923e00cb348ded6b8c46d4b4b 
>   src/tests/slave_tests.cpp d9d0a6abdfd56712ddad0a9afebd451c0ec51fc1 
> 
> Diff: https://reviews.apache.org/r/51865/diff/
> 
> 
> Testing
> -------
> 
> make check on Mac OS
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message