mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 51909: Added benchmarks for new registry operations.
Date Fri, 16 Sep 2016 00:23:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51909/#review149159
-----------------------------------------------------------


Ship it!




Ship It!

- Vinod Kone


On Sept. 15, 2016, 11:13 a.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51909/
> -----------------------------------------------------------
> 
> (Updated Sept. 15, 2016, 11:13 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> These benchmarks cover:
> 
>   1. The time taken to make all registered agents unreachable and then
>      reachable. This is similar to what happens during a severe network
>      partition.
> 
>   2. The time taken to GC a significant fraction (50%) of the
>      unreachable list from the registry.
> 
> 
> Diffs
> -----
> 
>   src/tests/registrar_tests.cpp b04fc92c66449f1094212a534899e16d5f6f01bd 
> 
> Diff: https://reviews.apache.org/r/51909/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> The performance of the new registry operations seems quite acceptable for reasonable
cluster sizes, despite the fact that `PruneUnreachable` is quadratic time and `MarkSlaveReachable`
and `MarkSlaveUnreachable` are both linear time. For the time being, optimizing these operations
doesn't seem like it is needed urgently.
> 
> ```
> [ RUN      ] SlaveCount/Registrar_BENCHMARK_Test.GcManyAgents/0
> Garbage collected 5000 agents in 166351us
> [       OK ] SlaveCount/Registrar_BENCHMARK_Test.GcManyAgents/0 (7316 ms)
> [ RUN      ] SlaveCount/Registrar_BENCHMARK_Test.GcManyAgents/1
> Garbage collected 10000 agents in 427487us
> [       OK ] SlaveCount/Registrar_BENCHMARK_Test.GcManyAgents/1 (15048 ms)
> [ RUN      ] SlaveCount/Registrar_BENCHMARK_Test.GcManyAgents/2
> Garbage collected 15000 agents in 587876us
> [       OK ] SlaveCount/Registrar_BENCHMARK_Test.GcManyAgents/2 (22844 ms)
> [ RUN      ] SlaveCount/Registrar_BENCHMARK_Test.GcManyAgents/3
> Garbage collected 25000 agents in 1.170591secs
> [       OK ] SlaveCount/Registrar_BENCHMARK_Test.GcManyAgents/3 (49469 ms)
> [ RUN      ] SlaveCount/Registrar_BENCHMARK_Test.MarkUnreachableThenReachable/0
> Marked 10000 agents unreachable in 3.040816secs
> Marked 10000 agents reachable in 2.322533secs
> [       OK ] SlaveCount/Registrar_BENCHMARK_Test.MarkUnreachableThenReachable/0 (7490
ms)
> [ RUN      ] SlaveCount/Registrar_BENCHMARK_Test.MarkUnreachableThenReachable/1
> Marked 20000 agents unreachable in 8.192604secs
> Marked 20000 agents reachable in 5.041321secs
> [       OK ] SlaveCount/Registrar_BENCHMARK_Test.MarkUnreachableThenReachable/1 (18846
ms)
> [ RUN      ] SlaveCount/Registrar_BENCHMARK_Test.MarkUnreachableThenReachable/2
> Marked 30000 agents unreachable in 15.21931secs
> Marked 30000 agents reachable in 8.857088secs
> [       OK ] SlaveCount/Registrar_BENCHMARK_Test.MarkUnreachableThenReachable/2 (32296
ms)
> [ RUN      ] SlaveCount/Registrar_BENCHMARK_Test.MarkUnreachableThenReachable/3
> Marked 50000 agents unreachable in 39.277686secs
> Marked 50000 agents reachable in 18.483256secs
> [       OK ] SlaveCount/Registrar_BENCHMARK_Test.MarkUnreachableThenReachable/3 (73369
ms)
> ```
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message