mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 51884: Removed tasks belonging to a task group from queued tasks.
Date Wed, 14 Sep 2016 17:53:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51884/#review148942
-----------------------------------------------------------


Fix it, then Ship it!





src/slave/slave.cpp (line 2212)
<https://reviews.apache.org/r/51884/#comment216466>

    s/already/also/



src/slave/slave.cpp (line 2213)
<https://reviews.apache.org/r/51884/#comment216467>

    s/also//


- Vinod Kone


On Sept. 14, 2016, 9:33 a.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51884/
> -----------------------------------------------------------
> 
> (Updated Sept. 14, 2016, 9:33 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> When sending the `LAUNCH_GROUP` event to the executor, we were
> not removing the tasks present in the task group from queued
> tasks. This resulted in the tasks being erroneously still
> being present in queued tasks thereby not able to receive
> terminal status updates from the executor.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.cpp 2c7b5ada1aa81babb9ceee0c9f928685878a778c 
> 
> Diff: https://reviews.apache.org/r/51884/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message