mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 51706: Tweaked logging for UnregisterSlaveMessage handler.
Date Mon, 12 Sep 2016 22:53:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51706/#review148618
-----------------------------------------------------------


Ship it!




Ship It!

- Vinod Kone


On Sept. 7, 2016, 9:35 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51706/
> -----------------------------------------------------------
> 
> (Updated Sept. 7, 2016, 9:35 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-5965
>     https://issues.apache.org/jira/browse/MESOS-5965
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Remove a redundant log line: rather than logging when we receive
> an UnregisterSlaveMessage, it is sufficient to log how we handle
> that message. Also ensure that we log when ignoring an agent
> unregister message for an unknown agent, and do some minor code
> cleanup.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp b2a19a645528e8fc1fd48f5ac9929d38c9a76b49 
> 
> Diff: https://reviews.apache.org/r/51706/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message