mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 51371: Fixed flakiness in MasterAuthorizationTest.SlaveDisconnected.
Date Mon, 12 Sep 2016 21:29:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51371/#review148596
-----------------------------------------------------------


Ship it!




Ship It!

- Vinod Kone


On Aug. 29, 2016, 9:51 a.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51371/
> -----------------------------------------------------------
> 
> (Updated Aug. 29, 2016, 9:51 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-4049
>     https://issues.apache.org/jira/browse/MESOS-4049
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The goal of this test is to check this interleaving:
> 
>   task launch: block on authorization
>   slave terminates gracefully: removed by master
>   auth succeeds: we expect the task launch to fail
> 
> However, the test neglected to ensure that slave removal was completed
> before allowing authorization to succeed.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_authorization_tests.cpp a6399f1b958705b87418b40d3771b25a37d49682 
> 
> Diff: https://reviews.apache.org/r/51371/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message