mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 51475: Added an equality operator for `TaskGroupInfo`/`TaskInfo`.
Date Mon, 12 Sep 2016 20:31:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51475/#review148578
-----------------------------------------------------------


Fix it, then Ship it!





src/common/type_utils.cpp (line 417)
<https://reviews.apache.org/r/51475/#comment216037>

    Add a TODO to do a proper equality check instead of serialization?


- Vinod Kone


On Sept. 12, 2016, 8:21 p.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51475/
> -----------------------------------------------------------
> 
> (Updated Sept. 12, 2016, 8:21 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-6076
>     https://issues.apache.org/jira/browse/MESOS-6076
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This is needed for storing `TaskGroupInfo` in a list and then
> invoking `std::find()`/`std::remove()` on it. Also added
> a basic test in `src/tests/common/type_utils_tests.cpp`.
> 
> 
> Diffs
> -----
> 
>   include/mesos/type_utils.hpp d10b66345e1a70801050d2cf2db63d76fbf9bc8c 
>   src/Makefile.am fa71381741083d3148ddaec715a862d65fc5c990 
>   src/common/type_utils.cpp c7d50334b4e56bc0eb5473b9f9277465b607334f 
>   src/tests/common/type_utils_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/51475/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message