mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haosdent huang <haosd...@gmail.com>
Subject Re: Review Request 51787: Refactored cpu isolator associated test cases.
Date Mon, 12 Sep 2016 04:46:29 GMT


> On Sept. 12, 2016, 4:27 a.m., Jie Yu wrote:
> > src/tests/containerizer/cgroups_isolator_tests.cpp, line 481
> > <https://reviews.apache.org/r/51787/diff/2/?file=1495691#file1495691line481>
> >
> >     Good call removing `TEST_F(LimitedCpuIsolatorTest, ROOT_CGROUPS_CFS_Big_Quota)`.
> >     
> >     After reading
> >     https://issues.apache.org/jira/browse/MESOS-1049
> >     
> >     and comments in
> >     https://reviews.apache.org/r/18639
> >     https://reviews.apache.org/r/18642/
> >     
> >     Let's add another
> >     `CgroupsAnyHierarchyTest.ROOT_CGROUPS_CFS_Big_Quota_Decimal` that write a decimal
value to catch regressions.

Address this at https://reviews.apache.org/r/51794/


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51787/#review148451
-----------------------------------------------------------


On Sept. 12, 2016, 4:45 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51787/
> -----------------------------------------------------------
> 
> (Updated Sept. 12, 2016, 4:45 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, and Qian Zhang.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Refactored cpu isolator associated test cases.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am fa71381741083d3148ddaec715a862d65fc5c990 
>   src/tests/containerizer/cgroups_isolator_tests.cpp c4e467c8227f9e4129b05d173812592f39a04e06

>   src/tests/containerizer/cpu_isolator_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/51787/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message