mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <>
Subject Re: Review Request 51654: Fixed help display for mesos-containerizer subcommands.
Date Wed, 07 Sep 2016 16:28:55 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Sept. 7, 2016, 6:28 p.m.)

Review request for mesos and Jie Yu.

Summary (updated)

Fixed help display for mesos-containerizer subcommands.

Repository: mesos


In this patch we add help displays for all current containerizer
subcommands. We also trim existing display of the usage; here we use
that `Flags::usage` already takes care of providing a header.

Diffs (updated)

  src/slave/containerizer/mesos/isolators/network/cni/cni.cpp d17a45fe17bb74cbf9ae421dc8a492e5dc5f1a00

  src/slave/containerizer/mesos/launch.cpp 13b65d82e029650e150eb2bc3647d95af167bd72 
  src/slave/containerizer/mesos/mount.cpp dbd7853a43ee1402f2f91d933a657010efdd76b0 


Testing (updated)

make check

Confirmed by explicitly invoking

    $ mesos-containerizer launch --help
    $ mesos-containerizer mount --help
    $ mesos-containerizer network-cni-setup --help


Benjamin Bannier

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message