mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Avinash sridharan <avin...@mesosphere.io>
Subject Review Request 51643: Modified network file setup in `network/cni` isolator.
Date Tue, 06 Sep 2016 15:56:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51643/
-----------------------------------------------------------

Review request for mesos.


Repository: mesos


Description
-------

In case /etc/hosts and /etc/hostname files are not present in the host
filesystem, we were ignoring these files and assuming that they would
not be required by the executor when it is launched in a new network
namespace. This assumption is incorrect, since the executor needs
/etc/hosts in the new network namespace to resolve its hostname.
Hence, we are explicitly creating these files in the host file system
in case they are not present, so that containers /etc/hosts and
/etc/hostname can be mounted on these mount points. This solves the
problem in distributions such as CoreOS that don't have /etc/hosts in
their host filesystem.


Diffs
-----

  src/slave/containerizer/mesos/isolators/network/cni/cni.cpp d17a45fe17bb74cbf9ae421dc8a492e5dc5f1a00


Diff: https://reviews.apache.org/r/51643/diff/


Testing
-------

make check


Thanks,

Avinash sridharan


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message