mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 50706: Added test cases for PARTITION_AWARE behavior.
Date Tue, 06 Sep 2016 14:14:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50706/#review147827
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/partition_tests.cpp (line 462)
<https://reviews.apache.org/r/50706/#comment215102>

    re-register



src/tests/partition_tests.cpp (line 466)
<https://reviews.apache.org/r/50706/#comment215103>

    re-registration



src/tests/partition_tests.cpp (line 613)
<https://reviews.apache.org/r/50706/#comment215106>

    new line after this comment since it applies two blocks below; or just move the "sched2..."
part to #620.



src/tests/partition_tests.cpp (lines 647 - 651)
<https://reviews.apache.org/r/50706/#comment215108>

    instead of having expectations on the FrameworkRegisteredMessage, why not leverage registered
callback?
    
    Future<Nothing> registered1;
    Future<Nothing> registered2;
    EXPECT_CALL(sched1, registered(&driver1, _, _))
      .WillOnce(FutureSatisfy(&registered1));
    EXPECT_CALL(sched1, registered(&driver2, _, _))
      .WillOnce(FutureSatisfy(&registered2));



src/tests/partition_tests.cpp (line 710)
<https://reviews.apache.org/r/50706/#comment215115>

    hmm. didn't realize that the TODO in `Master::reconcile` regarding assumption is actually
wrong! tasks could be unknown to the master but known to the agent. not sure why we made that
assumption.



src/tests/partition_tests.cpp (line 723)
<https://reviews.apache.org/r/50706/#comment215111>

    `SlaveObserver`



src/tests/partition_tests.cpp (line 867)
<https://reviews.apache.org/r/50706/#comment215112>

    re-registers



src/tests/partition_tests.cpp (line 887)
<https://reviews.apache.org/r/50706/#comment215113>

    re-registration



src/tests/partition_tests.cpp (line 934)
<https://reviews.apache.org/r/50706/#comment215114>

    re-registers


- Vinod Kone


On Aug. 29, 2016, 9:49 a.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50706/
> -----------------------------------------------------------
> 
> (Updated Aug. 29, 2016, 9:49 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-4049
>     https://issues.apache.org/jira/browse/MESOS-4049
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added test cases for PARTITION_AWARE behavior.
> 
> 
> Diffs
> -----
> 
>   src/tests/partition_tests.cpp f3142ad8d50daafcdb70ad9dbb2772f8ba30db00 
> 
> Diff: https://reviews.apache.org/r/50706/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message