mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 46187: Terminate when receiving the ACK of terminal status update.
Date Tue, 06 Sep 2016 11:33:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46187/#review147808
-----------------------------------------------------------




src/launcher/executor.cpp (lines 226 - 231)
<https://reviews.apache.org/r/46187/#comment215081>

    move this #220.
    
    just look inside `updates` map. see comment below.



src/launcher/executor.cpp (lines 227 - 228)
<https://reviews.apache.org/r/46187/#comment215083>

    How about:
    
    // NOTE: The executor receives an ACK iff it uses the HTTP library. No ACK
    // will be received if V0ToV1Adapter is used.



src/launcher/executor.cpp (lines 521 - 522)
<https://reviews.apache.org/r/46187/#comment215084>

    why this change?



src/launcher/executor.cpp (line 674)
<https://reviews.apache.org/r/46187/#comment215085>

    s/driver/adapter/



src/launcher/executor.cpp (line 675)
<https://reviews.apache.org/r/46187/#comment215086>

    s/sent/is sent/



src/launcher/executor.cpp (lines 678 - 681)
<https://reviews.apache.org/r/46187/#comment215087>

    // 2. For HTTP based executor, this is a fail safe in case the
    // agent doesn't send an ACK for the terminal update for some reason.



src/launcher/executor.cpp (line 682)
<https://reviews.apache.org/r/46187/#comment215088>

    hmm. what's the guarantee that an HTTP based executor receives an ACK within a second?
what if the agent is down?



src/launcher/executor.cpp (line 751)
<https://reviews.apache.org/r/46187/#comment215079>

    don't think you need `terminalStatusUUID`. you can just look in the `updates` map.



src/launcher/executor.cpp (lines 810 - 811)
<https://reviews.apache.org/r/46187/#comment215080>

    see above. kill this.


- Vinod Kone


On Aug. 30, 2016, 6:01 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46187/
> -----------------------------------------------------------
> 
> (Updated Aug. 30, 2016, 6:01 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-5276
>     https://issues.apache.org/jira/browse/MESOS-5276
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Terminate when receiving the ACK of terminal status update.
> 
> 
> Diffs
> -----
> 
>   src/launcher/executor.cpp 5370634ef9e6f3ac9717fed71f6a77707026a16a 
> 
> Diff: https://reviews.apache.org/r/46187/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message