mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ammar Askar <>
Subject Review Request 50002: Allow all flags load methods to specify a prefix.
Date Wed, 13 Jul 2016 20:53:22 GMT

This is an automatically generated e-mail. To reply, visit:

Review request for mesos, Greg Mann and Vinod Kone.

Bugs: MESOS-5613

Repository: mesos


Allow all flags load methods to specify a prefix.

This also refactors the prefix logic into one place, so that's nice.
Required for the actual fix for passing work_dir in local.


  3rdparty/stout/include/stout/flags/flags.hpp dd9362772d1fbd32638fc7e70126fd49d4a03c68 
  3rdparty/stout/tests/flags_tests.cpp 77f3a6af110da1ffcdf2b7ab2b66431a6b5c91d3 



Added additional tests to flags_tests.cpp to ensure that prefix works on the other methods.

`make check` passes


Ammar Askar

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message