mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 49419: Updated GetTasks v1 call in master.
Date Thu, 30 Jun 2016 23:34:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49419/
-----------------------------------------------------------

(Updated June 30, 2016, 11:33 p.m.)


Review request for mesos, Anand Mazumdar, Jay Guo, and Zhitao Li.


Changes
-------

addressed comments. NNFR.


Bugs: MESOS-5493
    https://issues.apache.org/jira/browse/MESOS-5493


Repository: mesos


Description
-------

The response now distinguishes between active tasks, completed tasks,
pending tasks and orphan tasks to make it easy for clients.
Consequently got rid of offset, limit and offset in the Call because
they don't make sense when we have multiple fields in the response.


Diffs (updated)
-----

  include/mesos/master/master.proto 2e5d6eeb3a960e4f41c382d65321f18bb05ed6be 
  include/mesos/v1/master/master.proto 93157d57dcc53b54fed2ebbc4772c689ddba2119 
  src/master/http.cpp d5f4e77717db4ddf2a3ae7321db3168fde6c255d 
  src/master/validation.cpp 6939d0e6ac3dbddc10f0315bd0a696a1f71634e2 
  src/tests/api_tests.cpp b3127b716480223a6f23b7908bf6bc1808120f80 

Diff: https://reviews.apache.org/r/49419/diff/


Testing
-------

make check


Thanks,

Vinod Kone


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message