mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Review Request 49479: Removed --sandbox flag from mesos-containerizer launch command.
Date Thu, 30 Jun 2016 23:22:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49479/
-----------------------------------------------------------

Review request for mesos, Benjamin Mahler, Gilbert Song, and Ian Downes.


Bugs: MESOS-5753
    https://issues.apache.org/jira/browse/MESOS-5753


Repository: mesos


Description
-------

This flag is unnecessary. The caller should calculate the current
working directory for the command, instead of doing the calculation in
this helper binary. This patch moved the calculation to the caller and
simplified this helper binary.


Diffs
-----

  src/slave/containerizer/mesos/containerizer.cpp 63cf92217054fab43c843379c86e25ce7f07c7d9

  src/slave/containerizer/mesos/launch.hpp c716e0396736d1f2f60ec31540f12f4f7597d081 
  src/slave/containerizer/mesos/launch.cpp 83f4d7f28c066a605aa84862eca9fde900ec96c6 
  src/tests/containerizer/launch_tests.cpp 3e36f2f7ab89b98de2c1a971e4ecca58c13ad642 
  src/tests/containerizer/port_mapping_tests.cpp 1c50cf545392488cf1e2d51d8e03887bebef5e75


Diff: https://reviews.apache.org/r/49479/diff/


Testing
-------

make check


Thanks,

Jie Yu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message