mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 48904: Updated allocator initialize() to include fairnessExcludeResourceNames.
Date Thu, 30 Jun 2016 01:51:07 GMT


> On 六月 29, 2016, 5:13 p.m., Klaus Ma wrote:
> > src/master/master.cpp, line 830
> > <https://reviews.apache.org/r/48904/diff/3/?file=1432471#file1432471line830>
> >
> >     Please check whether the resource name is valid. We only support cpus, mem,
disk, ports, gpus for now.

One question is that end user can specify customized resources when agent start up by adding
some other resources, such as ` --resources="cpus:8;mem:8000;foo:10;bar:20"`, so here I'm
not validating the resources, but just make the sorter ignore the resource names in the `allocator_fairness_excluded_resource_names`,
what do you say?


- Guangya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48904/#review140016
-----------------------------------------------------------


On 六月 29, 2016, 12:16 p.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48904/
> -----------------------------------------------------------
> 
> (Updated 六月 29, 2016, 12:16 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-5620
>     https://issues.apache.org/jira/browse/MESOS-5620
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated allocator initialize() to include fairnessExcludeResourceNames.
> 
> 
> Diffs
> -----
> 
>   include/mesos/allocator/allocator.hpp 98025bc182d92098bd4018177a6ae28135d8de95 
>   src/master/allocator/mesos/allocator.hpp f096d2b7813580fb28e77a2803e290edf1ebda31 
>   src/master/allocator/mesos/hierarchical.hpp 98a1f69f14b967c8d01f8a680771c9d28fac14e4

>   src/master/allocator/mesos/hierarchical.cpp c3639342335499a04a23147a4205f1b475c123fa

>   src/master/master.cpp 907233b015919f437fb2ebd25875217930b301b4 
>   src/tests/allocator.hpp 41a31ae5d2c8fb8eb902a82d893be570db0da3bd 
>   src/tests/api_tests.cpp b3127b716480223a6f23b7908bf6bc1808120f80 
>   src/tests/master_allocator_tests.cpp 7910f5532bf36ed92100839eac6c6f6a18838ffa 
>   src/tests/master_quota_tests.cpp b9bc49b1ef55d6ea57d94971905d70244f982e9f 
>   src/tests/persistent_volume_endpoints_tests.cpp 6c85e19eeaa69bf3a4e3077261331191db6eec06

>   src/tests/reservation_endpoints_tests.cpp 3ee59d5db0089dd59acfe48a77910d069ffc377b

>   src/tests/reservation_tests.cpp d7e90bc67a55a909be70691a1108493c33743b02 
>   src/tests/resource_offers_tests.cpp 046adaedf9121655f377f503bb30437803bf0005 
>   src/tests/slave_recovery_tests.cpp e6e7b8e3d71886eb8749122bd7b441857983d574 
> 
> Diff: https://reviews.apache.org/r/48904/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message