mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <>
Subject Re: Review Request 49404: Changed the SocketManager to pass "Sockets" by value.
Date Thu, 30 Jun 2016 01:11:09 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated June 29, 2016, 6:11 p.m.)

Review request for mesos, Benjamin Mahler and Artem Harutyunyan.


Separated out the race fix into a smaller patch, which goes in the opposite direction as this
patch (adds vs removes pointers).

Changed this patch to remove all `Socket*`s.

Summary (updated)

Changed the SocketManager to pass "Sockets" by value.

Bugs: MESOS-5748

Repository: mesos

Description (updated)

`Sockets` is already a reference-counted `shared_ptr` under the covers.
By passing around `Sockets` by value, we avoid potentially deleting
a reference while the same reference is in use by another function.

Diffs (updated)

  3rdparty/libprocess/src/process.cpp 9bae71246e751e491be5a989eea8aca29c9aa751 



make check (OSX)

3rdparty/libprocess/libprocess-tests --gtest_filter="ProcessRemoteLinkTest.RemoteLink"  --gtest_break_on_failure


Joseph Wu

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message