mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 49352: Added a flag parser for hashset<std::string>.
Date Wed, 29 Jun 2016 23:07:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49352/#review140068
-----------------------------------------------------------




src/common/parse.hpp (line 144)
<https://reviews.apache.org/r/49352/#comment205383>

    Can we use std::set for now?



src/common/parse.hpp (lines 148 - 155)
<https://reviews.apache.org/r/49352/#comment205382>

    We should let the user know that duplicate entries are an error. Otherwise, if intending
to accomplish something via the duplicates and we silently accept them, they are unaware that
the duplicates have no effect.


- Benjamin Mahler


On June 29, 2016, 12:12 p.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49352/
> -----------------------------------------------------------
> 
> (Updated June 29, 2016, 12:12 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-5743
>     https://issues.apache.org/jira/browse/MESOS-5743
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a flag parser for hashset<std::string>.
> 
> 
> Diffs
> -----
> 
>   src/common/parse.hpp 19e56dbeb765f8bec92e0a3615f6f7c12466fa9e 
> 
> Diff: https://reviews.apache.org/r/49352/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message