mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Re: Review Request 48250: Cleaned up task state reconciliation tests.
Date Wed, 08 Jun 2016 11:25:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48250/
-----------------------------------------------------------

(Updated June 8, 2016, 11:25 a.m.)


Review request for mesos, Benjamin Mahler and Vinod Kone.


Changes
-------

Set "required" field but document that it is ignored.


Bugs: MESOS-5547
    https://issues.apache.org/jira/browse/MESOS-5547


Repository: mesos


Description (updated)
-------

Document that when doing task state reconciliation, the
`state` field in the input TaskStatus should be set to a
dummy value that will be ignored by Mesos.

Along the way, make use of C++11 initializer lists.


Diffs (updated)
-----

  src/tests/reconciliation_tests.cpp 092dff165097315cbebd20bc32fb9fcf5370d136 

Diff: https://reviews.apache.org/r/48250/diff/


Testing
-------

make check


Thanks,

Neil Conway


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message