mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <mazumdar.an...@gmail.com>
Subject Re: Review Request 48049: Implemented GET_LEADING_MASTER Call in v1 master API.
Date Mon, 30 May 2016 20:21:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48049/#review135541
-----------------------------------------------------------




src/internal/evolve.hpp (line 118)
<https://reviews.apache.org/r/48049/#comment200565>

    We don't need the templated arguments. Also, move this function to L58
    
    The signature would be just:
    
    ```cpp
    v1::MasterInfo evolve(const mesos::MasterInfo& masterInfo);
    ```



src/internal/evolve.cpp (lines 427 - 442)
<https://reviews.apache.org/r/48049/#comment200566>

    We don't need this:
    
    Just do:
    
    ```cpp
    v1::MasterInfo evolve(const mesos::MasterInfo& masterInfo)
    {
      return evolve<v1::MasterInfo>(masterInfo);
    }
    ```
    
    Also can you move this upto line L143 i.e. after `TaskStatus` evolve



src/master/http.cpp (lines 1203 - 1207)
<https://reviews.apache.org/r/48049/#comment200567>

    Just do:
    
    ```cpp
    response.mutable_get_leading_master()->mutable_master_info()->CopyFrom(evolve(master->info());
    ```


- Anand Mazumdar


On May 30, 2016, 7:56 p.m., Abhishek Dasgupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48049/
> -----------------------------------------------------------
> 
> (Updated May 30, 2016, 7:56 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-5497
>     https://issues.apache.org/jira/browse/MESOS-5497
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented GET_LEADING_MASTER Call in v1 master API and
> made a minor change in the test case for GET_LOGGING_LEVEL.
> 
> 
> Diffs
> -----
> 
>   src/internal/evolve.hpp 0fdda31 
>   src/internal/evolve.cpp 4f25f1a 
>   src/master/http.cpp c8d2f46 
>   src/master/master.hpp eeeccdf 
>   src/tests/api_tests.cpp 0b6bfad 
> 
> Diff: https://reviews.apache.org/r/48049/diff/
> 
> 
> Testing
> -------
> 
> On Ubuntu 16.04:
> 
> sudo GTEST_FILTER="*MasterAPITest*.*" make -j2 check
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message