mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Till Toenshoff <toensh...@me.com>
Subject Re: Review Request 48048: Added documentation for access_sandboxes and access_mesos_logs acls.
Date Mon, 30 May 2016 17:40:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48048/#review135528
-----------------------------------------------------------




docs/authorization.md (line 131)
<https://reviews.apache.org/r/48048/#comment200542>

    s/whoe/whose



docs/authorization.md (line 132)
<https://reviews.apache.org/r/48048/#comment200545>

    I have trouble understanding 
    ```
    _It still takes types ANY and NONE to allow or deny access._
    ```
    
    Why "still" - in which contrast?


- Till Toenshoff


On May 30, 2016, 4:36 p.m., Alexander Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48048/
> -----------------------------------------------------------
> 
> (Updated May 30, 2016, 4:36 p.m.)
> 
> 
> Review request for mesos, Adam B, Joerg Schad, and Michael Park.
> 
> 
> Bugs: MESOS-5153
>     https://issues.apache.org/jira/browse/MESOS-5153
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Modifies the file `acls.proto` to take into consideration the added
> authorization actions `access_sandboxes` and `access_mesos_logs`.
> 
> 
> Diffs
> -----
> 
>   docs/authorization.md 723d98c859bef04448b105905443d5e7beaa968c 
> 
> Diff: https://reviews.apache.org/r/48048/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message