mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joris Van Remoortere <joris.van.remoort...@gmail.com>
Subject Re: Review Request 47470: Stout: Added `path::temp_path`.
Date Wed, 25 May 2016 20:46:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47470/#review134831
-----------------------------------------------------------



As discussed offline:
Let's move this into the `os` namespace.
Let's rename this to `temp`.
Let's consider returning the `Path` type. If it doesn't make sense we can fall back to `string`.

- Joris Van Remoortere


On May 17, 2016, 4:02 p.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47470/
> -----------------------------------------------------------
> 
> (Updated May 17, 2016, 4:02 p.m.)
> 
> 
> Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, and
Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Stout: Added `path::temp_path`.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/Makefile.am 9b39ce32c0269479066cf7991afaeed65d8ab547 
>   3rdparty/stout/include/stout/path.hpp ef538045a8b7a1e3d8962c869317d86a85e0259f 
>   3rdparty/stout/include/stout/posix/path.hpp PRE-CREATION 
>   3rdparty/stout/include/stout/windows/path.hpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/47470/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message