mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex Clemmer <clemmer.alexan...@gmail.com>
Subject Review Request 47821: Remove SASL dependency for Windows builds.
Date Wed, 25 May 2016 18:45:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47821/
-----------------------------------------------------------

Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, and Michael
Park.


Bugs: MESOS-5450
    https://issues.apache.org/jira/browse/MESOS-5450


Repository: mesos


Description
-------

SASL is currently a hard dependency for Mesos. Per MESOS-5450, we expect
that some platforms will not support SASL (namely Windows), so this
commit will begin the first step in a several-step process of removing
it as a hard dependency.

For this first step, this commit will shed SASL dependency in libmesos
only for Windows builds. We do this by:

  (1) Adding a preprocessor symbol, `HAS_AUTHENTICATION` that wraps the
      SASL-dependent code, so that we can conditionally choose not to
      compile it.
  (2) Defining `HAS_AUTHENTICATION` on all Unix builds, and leaving it
      undefined on all Windows builds.
  (3) Logging an error and exiting the master if the user passes in
      flags that depend on SASL, such as `--authenticate`.

Notably, what we do *not* do is:

  (1) Shed SASL dependency in the tests.

The impact of this is that, on Windows, relevant libmesos tests will
either not compile, or not pass. Naturally, as tracked by MESOS-5450,
the second phase of this series will be to shed the test dependency as
well.


Diffs
-----

  cmake/CompilationConfigure.cmake 5c7833ceaed556cc4ffb650996e918c1a542c5f0 
  src/Makefile.am 447bc2ab511ad173d3d911be10992be0974f4584 
  src/master/master.cpp 35b428b0f7dee5954514d8860cfc498271ccf267 
  src/sched/sched.cpp 4693d0dc09afc3ddbbf34e166579b6a6d71c3e38 

Diff: https://reviews.apache.org/r/47821/diff/


Testing
-------


Thanks,

Alex Clemmer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message