mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kapil Arya <ka...@mesosphere.io>
Subject Re: Review Request 47753: Enabled building libprocess without building 3rdparty first.
Date Wed, 25 May 2016 11:06:26 GMT


> On May 25, 2016, 5 a.m., Till Toenshoff wrote:
> > Seems you still need to fix configure.ac within libprocess. When running a `bootstrap`
I am getting
> > ```
> > configure.ac:62: error: required file '3rdparty/Makefile.in' not found
> > configure.ac:64: error: required file '3rdparty/gmock_sources.cc.in' not found
> > ```

That is a somewhat non-trivial fix and so will be a separate patchset (post 0.29.0) :-/.


- Kapil


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47753/#review134732
-----------------------------------------------------------


On May 23, 2016, 10:49 p.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47753/
> -----------------------------------------------------------
> 
> (Updated May 23, 2016, 10:49 p.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Till Toenshoff.
> 
> 
> Bugs: MESOS-5445
>     https://issues.apache.org/jira/browse/MESOS-5445
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Doing a `make` inside libprocess would now automatically build bundled
> dependencies.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/Makefile.am 3c3249fe9799ba919ac7bd13e2ddb07a306737f0 
> 
> Diff: https://reviews.apache.org/r/47753/diff/
> 
> 
> Testing
> -------
> 
> `make clean` in 3rdparty/ followed by `make` in libprocess succeeds with this patch.
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message