mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dario Rexin <dario.re...@me.com>
Subject Re: Review Request 47804: Fixed a memory leak in SchedulerProcess.decline
Date Wed, 25 May 2016 03:46:19 GMT


> On May 25, 2016, 1:35 a.m., Vinod Kone wrote:
> > src/sched/sched.cpp, line 1353
> > <https://reviews.apache.org/r/47804/diff/1/?file=1392955#file1392955line1353>
> >
> >     Can you log the warning like we do in acceptOffers()?
> >     
> >     ```
> >     if (!savedOffers.contains(offerId)) {
> >       LOG(WARNING) << "Attempting to decline an unknown offer << offerId;
> >     }
> >     
> >     savedOffers.erase(offerId);
> >     
> >     ```

Thanks for the feedback. I updated the patch accordingly.


- Dario


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47804/#review134676
-----------------------------------------------------------


On May 25, 2016, 3:45 a.m., Dario Rexin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47804/
> -----------------------------------------------------------
> 
> (Updated May 25, 2016, 3:45 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: https://issues.apache.org/jira/browse/MESOS-5449
>     https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/MESOS-5449
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> MesosScheduler.declineOffers has been changed ~6 months ago to send a
> Decline message instead of calling acceptOffers with an empty list of
> task infos. The changed version of declineOffer however did not remove
> the offerId from the savedOffers map, causing a memory leak.
> 
> 
> Diffs
> -----
> 
>   src/sched/sched.cpp 9e55885 
> 
> Diff: https://reviews.apache.org/r/47804/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Dario Rexin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message