mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 46418: Refactored the `os::access` function between POSIX and Windows.
Date Tue, 24 May 2016 23:28:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46418/#review134661
-----------------------------------------------------------



Patch looks great!

Reviews applied: [46418]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 24, 2016, 9:36 p.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46418/
> -----------------------------------------------------------
> 
> (Updated May 24, 2016, 9:36 p.m.)
> 
> 
> Review request for mesos, Daniel Pravat, Alex Clemmer, and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-5237
>     https://issues.apache.org/jira/browse/MESOS-5237
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Refactored the `os::access` function between POSIX and Windows.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/Makefile.am ae4116b02474f2228d86ad4a9bbf69f9c1bb4342 
>   3rdparty/stout/include/stout/os.hpp 2a306ae87422300b586e9f627a3f125d8faac4db 
>   3rdparty/stout/include/stout/os/access.hpp PRE-CREATION 
>   3rdparty/stout/include/stout/posix/os.hpp 1a66184d86d6a0a13b8facfc9f969e09dd824725

>   3rdparty/stout/include/stout/windows/os.hpp 71a8c61335e2bce340447e94e855a6bd79c49dec

> 
> Diff: https://reviews.apache.org/r/46418/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message