mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Review Request 47716: Added auto-discovery to the NVidia GPU device isolator.
Date Mon, 23 May 2016 08:10:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47716/
-----------------------------------------------------------

Review request for mesos, Benjamin Mahler and Vikrama Ditya.


Bugs: MESOS-5257
    https://issues.apache.org/jira/browse/MESOS-5257


Repository: mesos


Description
-------

This commit enables auto-discovery of GPU devices for resource
enumeration. It is backwards compatible with the previous semantics
which forced you to both specify a `gpus` resource flag and a matching
`nvdia_gpu_devices` flag on the command line.  However, it is less
restrictive now.

By default, with no `nvidia_gpu_devices` flag or `gpus` resources
flag, the new auto-discovery will simply enumerate all of the GPUs on
the system. Specifying either an `nvidia_gpu_devices` flag or a `gpus`
resource flag will override auto-discovery, but each of these flags
can now be specified independently (whereas before you had to have
both).


Diffs
-----

  src/slave/containerizer/mesos/isolators/cgroups/devices/gpus/nvidia.hpp 502204650192d5ea44aa631eac8eb37e051843f0

  src/slave/containerizer/mesos/isolators/cgroups/devices/gpus/nvidia.cpp 8f81cb79c10261670efc9eaa8614751854f53806


Diff: https://reviews.apache.org/r/47716/diff/


Testing
-------

Test in follow-on commit https://reviews.apache.org/r/47717


Thanks,

Kevin Klues


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message