mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Re: Review Request 46540: Updated pkg-config file to include module dependency info.
Date Thu, 05 May 2016 04:10:18 GMT


> On May 4, 2016, 3:33 p.m., James Peach wrote:
> > configure.ac, line 591
> > <https://reviews.apache.org/r/46540/diff/1/?file=1355759#file1355759line591>
> >
> >     So in practice, libraries would be installed in either ``3rdparty/lib64`` or
``3rdparty/lib``, but not both?
> >     
> >     Is there a libtool or autoconf variable to figure that out?
> 
> Kapil Arya wrote:
>     On 32-bit, they'll be installed in lib. On 64-bit, it could be either :-(. I believe
there might be a way to figure it out but I am not so sure given that we are talking about
3rdparty software (with their own configure scripts) here. I'll try to think of a better alternative.

Another question ... I don't recall whether you actually need the link flags for modules?
all the 3rdparty libraries should already be present in the mesos process by the time module
are loaded, so you wouldn't need them at link time. Right?


- James


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46540/#review131691
-----------------------------------------------------------


On May 4, 2016, 3:22 p.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46540/
> -----------------------------------------------------------
> 
> (Updated May 4, 2016, 3:22 p.m.)
> 
> 
> Review request for mesos, Cody Maloney, Alex Clemmer, James Peach, and Timothy St. Clair.
> 
> 
> Bugs: MESOS-5250
>     https://issues.apache.org/jira/browse/MESOS-5250
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated pkg-config file to include module dependency info.
> 
> 
> Diffs
> -----
> 
>   configure.ac ae91a07e2bafd97566ac6e6873990302acad14c9 
>   mesos.pc.in a0cc66a77058bf4beaa21d7dd4208654c6185640 
> 
> Diff: https://reviews.apache.org/r/46540/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message