mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 46621: Added alias support for flags.
Date Sat, 30 Apr 2016 03:29:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46621/#review131240
-----------------------------------------------------------




3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp (line 498)
<https://reviews.apache.org/r/46621/#comment195143>

    I'm getting the following error when I attempt to apply this patch with 'apply-review.sh':
`3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp:498:  Redundant blank line
at the start of a code block should be deleted.  [whitespace/blank_line] [2]`


- Greg Mann


On April 30, 2016, 2 a.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46621/
> -----------------------------------------------------------
> 
> (Updated April 30, 2016, 2 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-5271
>     https://issues.apache.org/jira/browse/MESOS-5271
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This lets a user to load a flag either by the original name or an
> alias.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/flags/flag.hpp 2502d9e8a515b9adc1b3aa2f719e5710a0e7ef29

>   3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp c3cbcdb781e1c282d381de1ad2bf4f386ee1db21

> 
> Diff: https://reviews.apache.org/r/46621/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message