mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <>
Subject Review Request 46825: Fully-typed all FlagsBase::add overloads.
Date Fri, 29 Apr 2016 09:37:49 GMT

This is an automatically generated e-mail. To reply, visit:

Review request for mesos, Alexander Rukletsov and Vinod Kone.

Bugs: MESOS-3335

Repository: mesos


Fully-typed all FlagsBase::add overloads.


  3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp c3cbcdb781e1c282d381de1ad2bf4f386ee1db21

  3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp 66e16abe914e2a1ee7599bab857ff478b7ec20dc

  3rdparty/libprocess/3rdparty/stout/tests/subcommand_tests.cpp 9213d6b9faec30b5be320ab37ca29c2406c964ac



make check (OS X clang-trunk w/o optimizations)

The mesos tests suite do not execute at all with an optimizing clang-trunk since copying of
the `map` inside `FlagsBase` reference random memory leading to `SEGFAULTs`. With these patches
all of `stout-tests` and `libprocess-tests` can be executed, but some remaining failures persist
in `mesos-tests` (their number is reduced though).


Benjamin Bannier

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message