mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ben Mahler <benjamin.mah...@gmail.com>
Subject Re: Review Request 46730: Cleanup syscalls logic.
Date Wed, 27 Apr 2016 19:41:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46730/#review130831
-----------------------------------------------------------



Could you also update the testing section? How did you ensure this compiles on the affected
architectures?


src/linux/cgroups.cpp (line 25)
<https://reviews.apache.org/r/46730/#comment194729>

    Hm.. where is this header located?
    
    I'd expect to find a unistd.h here:
    https://github.com/apache/mesos/tree/master/src/linux



src/linux/ns.hpp (lines 160 - 161)
<https://reviews.apache.org/r/46730/#comment194730>

    This looks like a similar change but it would be great to split it into a separate patch.
It's not immediately obvious to me why `SYS_setns` is being changed in favor of `__NR_setns`.
Can you add some some background information in the review description?


- Ben Mahler


On April 27, 2016, 11:44 a.m., Tomasz Janiszewski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46730/
> -----------------------------------------------------------
> 
> (Updated April 27, 2016, 11:44 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Zhiwei Chen, and haosdent huang.
> 
> 
> Bugs: MESOS-5263
>     https://issues.apache.org/jira/browse/MESOS-5263
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Used `<linux/unistd.h>` and removed uncessary condition complie.
> 
> 
> Diffs
> -----
> 
>   src/linux/cgroups.cpp b57ec05d3e0bf0bc1bf50fca9a9ede767f204253 
>   src/linux/fs.cpp 81f040e5c7ed7cbca569f5d43cb5afc5da1b5e64 
>   src/linux/ns.hpp 244a811b299c29b1dcd6652bd26e861e04df3f54 
> 
> Diff: https://reviews.apache.org/r/46730/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Tomasz Janiszewski
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message