mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 46569: Parameterized agent endpoint authorization tests on tested endpoint.
Date Wed, 27 Apr 2016 08:59:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46569/
-----------------------------------------------------------

(Updated April 27, 2016, 10:59 a.m.)


Review request for mesos and Adam B.


Changes
-------

Addressed offline comments from alexr.

* changed name of parameterized test
* enhance fixture
* split test into smaller units


Bugs: MESOS-5164
    https://issues.apache.org/jira/browse/MESOS-5164


Repository: mesos


Description
-------

At the moment we only provide a harness for `GET` methods, but will
generalize this further once we authorize `POST` requests against
agent endpoints as well.


Diffs (updated)
-----

  src/tests/slave_authorization_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/46569/diff/


Testing
-------

make check (OS X, clang trunk w/o optimization)


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message