mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Park <mp...@apache.org>
Subject Re: Review Request 46608: Libprocess: Implemented `subprocess_windows.cpp`.
Date Tue, 26 Apr 2016 23:03:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46608/#review130682
-----------------------------------------------------------




3rdparty/libprocess/src/subprocess_windows.cpp (line 77)
<https://reviews.apache.org/r/46608/#comment194535>

    Indent 2 spaces.



3rdparty/libprocess/src/subprocess_windows.cpp (line 79)
<https://reviews.apache.org/r/46608/#comment194537>

    `s/foreach(/foreach (/`



3rdparty/libprocess/src/subprocess_windows.cpp (line 153)
<https://reviews.apache.org/r/46608/#comment194534>

    Shouldn't we just `return duplicate;` here? Falling through and "leveraging" the `return
handle` on the next line seems like a bad pattern to set.


- Michael Park


On April 23, 2016, 11:41 p.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46608/
> -----------------------------------------------------------
> 
> (Updated April 23, 2016, 11:41 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere,
Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Bugs: MESOS-3637
>     https://issues.apache.org/jira/browse/MESOS-3637
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Libprocess: Implemented `subprocess_windows.cpp`.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/subprocess_windows.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46608/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message