mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <>
Subject Re: Review Request 46588: Added URI struct to stout.
Date Tue, 26 Apr 2016 00:59:37 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated April 25, 2016, 5:59 p.m.)

Review request for mesos, Gilbert Song, Artem Harutyunyan, Jie Yu, and Jojy Varghese.


Fixed user_info parsing (which is much more expressive than the previous diff allowed).
Added leading slash for `path`, which is more intuitive.
Added surrounding brackets for IPv6 hosts.
Fixed typo for fragment parsing.

Added a ton of tests.

Bugs: MESOS-5254

Repository: mesos


This will replace the `mesos::URI` protobuf currently used by the 

Diffs (updated)

  3rdparty/libprocess/3rdparty/stout/ 08ede41dcedc755933d656de58d93796e657749d

  3rdparty/libprocess/3rdparty/stout/include/ 33ddb06e25920096f2d16d4f372129ee2f6a8721

  3rdparty/libprocess/3rdparty/stout/include/stout/uri.hpp PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/tests/uri_tests.cpp PRE-CREATION 



make check (OSX) GTEST_FILTER="URITest*"

Ran a clean build (make check) on:

* Ubuntu 12, 14, 15
* CentOS 6, 7
* Debian 8


Joseph Wu

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message